Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ErrorSummary::listClass() and ErrorSummary::addListClass() #274

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Nov 21, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Nov 21, 2023

PR Summary

  • Upgraded version of 'yiisoft/html' library
    The system’s requirements have been updated to use a newer version of the 'yiisoft/html' library to provide enhanced features and improved performance.

  • Enhancements to the ErrorSummary class

    • Addition of 'addListClass()' and 'listClass()' methods: These new features allow us to modify the design of the list container by providing more flexibility in applying CSS classes.
    • Upgraded 'listClass()' function: The function has been improved to swap out old CSS classes with a fresh set, which results in greater control over the visual aesthetics.
    • Testing capabilities for new methods: Tests have been put into place to ensure these new methods operate correctly and enhance our system's reliability.
  • Updated ErrorSummaryTest

    • Addition of tests for new methods: The testing class for ErrorSummary, ErrorSummaryTest, has been updated accordingly to cover the newly implemented methods, reinforcing the robustness of our system.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dad3a5a) 98.92% compared to head (7ed129a) 98.93%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #274   +/-   ##
=========================================
  Coverage     98.92%   98.93%           
- Complexity      855      857    +2     
=========================================
  Files            48       48           
  Lines          2521     2529    +8     
=========================================
+ Hits           2494     2502    +8     
  Misses           27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit 94e148e into master Nov 21, 2023
@vjik vjik deleted the list-class branch November 21, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants